[Runtime] Support clear global memory allocators #16066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Nov 3, 2023
src/runtime/memory/memory_manager.cc
Outdated
| void MemoryManager::Clear() { | ||
| MemoryManager* m = MemoryManager::Global(); | ||
| std::lock_guard<std::mutex> lock(m->mu_); | ||
| m->allocators_.clear(); |
There was a problem hiding this comment.
let us iterate over each allocator and clear each of the freed entries, as oppose to clear the vector, which can cause issues when some of the allocated storage from the allocators get retained and deleted after clear
There was a problem hiding this comment.
Thanks for pointing it out. Just pushed a new commit, not sure if it addresses in the exactly same way as you mentioned.
|
Any updates? The latest rebase/merge will depend on this PR |
tqchen
reviewed
Nov 5, 2023
| @@ -166,6 +167,18 @@ Allocator* MemoryManager::GetAllocator(Device dev, AllocatorType type) { | |||
| return it->second.at(type).get(); | |||
| } | |||
|
|
|||
| void MemoryManager::Clear() { | |||
| MemoryManager* m = MemoryManager::Global(); | |||
There was a problem hiding this comment.
We need to add a Clear interface to base Allocator, and iterate over the allocators, to call Allocator->Clear() without removing any allocators
MasterJH5574
force-pushed
the
tvm-dev/2023-11-03-memory-manager-clear
branch
from
7d0c218 to
bcb2262
Compare
This PR supports clearing up all the allocated memory. Prior to this PR, all the allocated memory are managed in the pool of memory manager. The allocated memory in the pool is on hold and never freed. Consequently, the pool size always goes up monotonically within a single run in a process. While good to save time of memory allocation, in some cases (e.g., on mobile phones which may have running memory limit) we need to clear the pool and free all the memory in order to prevent the pool from endlessly growing up and some of allocated memory not being effectively utilized (fragmentation). Therefore, this PR introduces a PackedFunc that helps clean up the memory manager, releasing all the allocated memory. Runtime apps can decide when to invoke this PackedFunc and clean up the pool. Usually, this will happen at some app "reset" or "reload" stage.
MasterJH5574
force-pushed
the
tvm-dev/2023-11-03-memory-manager-clear
branch
from
bcb2262 to
21e77ce
Compare
tqchen
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports clearing up all the allocated memory.
Prior to this PR, all the allocated memory are managed in the pool of memory manager. The allocated memory in the pool is on hold and never freed. Consequently, the pool size always goes up monotonically within a single run in a process.
While good to save time of memory allocation, in some cases (e.g., on mobile phones which may have running memory limit) we need to clear the pool and free all the memory in order to prevent the pool from endlessly growing up and some of allocated memory not being effectively utilized (fragmentation).
Therefore, this PR introduces a PackedFunc that helps clean up the memory manager, releasing all the allocated memory. Runtime apps can decide when to invoke this PackedFunc and clean up the pool. Usually, this will happen at some app "reset" or "reload" stage.