[Hexagon] Add support for v73, make v68 default #14965
Merged
+56
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapdragon 8 Gen2 is v73, Hexagon SDK 5.2+ supports it.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
quic-sanirudh
approved these changes
May 26, 2023
The CPU version constants are enums, but they are initialized with values that are #defined in HexagonVersions.h. Before using any HEX_CPU_Vxx, check if the corresponding initializer has been #defined.
mei-ye
pushed a commit
to mei-ye/tvm
that referenced
this pull request
Jun 1, 2023
* [Hexagon] Add support for v73, make v68 default Snapdragon 8 Gen2 is v73, Hexagon SDK 5.2+ supports it. * Guard CPU versions with #ifdefs The CPU version constants are enums, but they are initialized with values that are #defined in HexagonVersions.h. Before using any HEX_CPU_Vxx, check if the corresponding initializer has been #defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapdragon 8 Gen2 is v73, Hexagon SDK 5.2+ supports it.