Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC] Update CUTLASS backend (SIMT support and codegen clean up) #14056

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

masahi
Copy link
Member

@masahi masahi commented Feb 20, 2023

The CUTLASS backend in Relay BYOC has been heavily refactored this month in the tlcpack/relax repo (as part of Relax BYOC effort). This PR brings the same change to apache/main and also adds SIMT fp32 support. All tests in test_cutlass.py pass.

Original PRs
Codegen clean up: tlc-pack/relax#442, tlc-pack/relax#451
SIMT fp32 support: tlc-pack/relax#448

@vinx13

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 20, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tqchen tqchen merged commit 5562d90 into apache:main Feb 20, 2023
@tqchen
Copy link
Member

tqchen commented Feb 20, 2023

Thank you @masahi

@Mousius
Copy link
Member

Mousius commented Feb 20, 2023

@tqchen as this isn't on the unity branch, in future could you allow others time to review in line with the code review guidelines?

@ekalda
Copy link
Contributor

ekalda commented Feb 20, 2023

Did this PR pass CI? I thought the upstream CI is broken with an Android problem.

@tqchen
Copy link
Member

tqchen commented Feb 20, 2023

In this case it is a positive change overall so I think merging would benefit the community. I have also reviewed and confirmed the related logics. Happy to followup with necessary steps if there are more comments.

The android CI breakage is not relevant to the particular change.

@tqchen
Copy link
Member

tqchen commented Feb 20, 2023

also copying @comaniac @Laurawly @vinx13 (the other main folks who are worked on cutlass BYOC modules besides @masahi ). Please send in comments in case I missed anything and happy to followup . Thanks @masahi for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants