-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metaschedule] EvolutionarySearchNode::State constructor typo fix #14002
[Metaschedule] EvolutionarySearchNode::State constructor typo fix #14002
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
@tvm-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shtinsa ,
It looks like the CI is failing because your PR has no description, could you please add one as well as a test case to demonstrate the issue this fixes?
@tvm-bot rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unfortunately it is a problem to create test. |
To be clear, this is not possible to create a test, as the code itself is a type, rather than a bug that leads to segfault or exceptions |
@shtinsa / @junrushao - I've tested similar things in the past, as far as I can see this is simply ensuring a more precise allocation which should be testable. Alas, TVM does not have good testing practices so I don't think there's an easy way forward. Thanks for the contribution @shtinsa, hope it doesn't unfix itself in future 😸 |
This PR fixes internal object initialization in EvolutionarySearchNode::State class. Unfortunately there is no way to prepare test case.