Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Extend reduction types supported by ScatterND #13946

Merged
merged 9 commits into from
Feb 13, 2023

Conversation

vvchernov
Copy link
Contributor

Support all current opsets described in ONNX docs for ScatterND. Particularly extend supported reduction attribute from ["update"] to ["update", "add", "mul", "min", "max"]. Also CI tests are updated for the op.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 10, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@vvchernov vvchernov force-pushed the vc/scatter_nd branch 3 times, most recently from 1160a6b to 008d0b6 Compare February 11, 2023 09:48
@vvchernov vvchernov changed the title WIP: [ONNX] Extend reduction types supported by ScatterND [ONNX] Extend reduction types supported by ScatterND Feb 11, 2023
Copy link
Contributor

@KJlaccHoeUM9l KJlaccHoeUM9l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echuraev echuraev merged commit 266ff51 into apache:main Feb 13, 2023
@vvchernov vvchernov deleted the vc/scatter_nd branch February 13, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants