Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][docker] Allow usage of ECR images in PRs #13590

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Conversation

driazati
Copy link
Member

@driazati driazati commented Dec 9, 2022

This fixes ecr_pull so that docker-images.ini can be updated with Docker images from a previous CI run for testing purposes

Example run: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cortexm/detail/PR-13590/4/pipeline/#step-80-log-9

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 9, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@driazati driazati force-pushed the test_ecr branch 2 times, most recently from 5ddbf9f to a539f85 Compare December 9, 2022 23:37
@driazati driazati changed the title [ci][test] Use Docker images from PR build [ci][docker] Allow usage of ECR images in PRs Dec 9, 2022
@driazati driazati marked this pull request as ready for review December 9, 2022 23:43
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@driazati driazati requested a review from areusch December 9, 2022 23:46
@driazati driazati merged commit 0dc26dd into apache:main Dec 10, 2022
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
This fixes `ecr_pull` so that `docker-images.ini` can be updated with Docker images from a previous CI run for testing purposes

Example run: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cortexm/detail/PR-13590/4/pipeline/#step-80-log-9
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
This fixes `ecr_pull` so that `docker-images.ini` can be updated with Docker images from a previous CI run for testing purposes

Example run: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cortexm/detail/PR-13590/4/pipeline/#step-80-log-9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants