Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bfloat16] Fixed dtype conversion in the arm_cpu injective schedule #13417

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

ashutosh-arm
Copy link
Contributor

Following on from the example conversion in ndarray.py,
in order to broaden the support for bfloat16 in the absence of
full support, this commit converts bfloat16 to uint16
in the injective schedule to enable full compilation
of Conv2D via arm_cpu schedules.

cc @leandron @ekalda

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 17, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: bfloat16 See #10317 for details
  • Built docs for commit 010d296 can be found here.

Generated by tvm-bot

@github-actions github-actions bot requested review from ekalda and leandron November 17, 2022 12:57
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a test case added, so that we can merge this?

@ashutosh-arm ashutosh-arm force-pushed the cortexa_fp16 branch 3 times, most recently from 9cf0679 to 39637e0 Compare December 5, 2022 10:40
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy for this to be merged once CI is green.

Thanks @ashutosh-arm

Following on from the example conversion in ndarray.py
to broaden the support for bfloat16 in the absence of
its full support, this commit converts bfloat16 to uint16
in the injective schedule to enable full compilation
of Conv2D via arm_cpu schedules.
@masahi masahi merged commit 75fd531 into apache:main Dec 8, 2022
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
…pache#13417)

Following on from the example conversion in ndarray.py
to broaden the support for bfloat16 in the absence of
its full support, this commit converts bfloat16 to uint16
in the injective schedule to enable full compilation
of Conv2D via arm_cpu schedules.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…pache#13417)

Following on from the example conversion in ndarray.py
to broaden the support for bfloat16 in the absence of
its full support, this commit converts bfloat16 to uint16
in the injective schedule to enable full compilation
of Conv2D via arm_cpu schedules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants