[Logging][Hexagon] Improve logging on Hexagon #13072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
supersat
force-pushed
the
improve-hexagon-logging
branch
from
2be47be to
046af15
Compare
|
More details and discussion at https://discuss.tvm.apache.org/t/improving-logging-on-hexagon-with-proposed-changes-to-logmessageimpl/13731 |
areusch
added
needs-triage
nverke
reviewed
Oct 20, 2022
nverke
reviewed
Oct 20, 2022
|
LGTM! Love to see those clean log lines in the discussion post! I want to see if this improves perf at all. |
janetsc
reviewed
Oct 21, 2022
janetsc
approved these changes
Oct 21, 2022
mehrdadh
requested changes
Oct 22, 2022
Currently Hexagon logging is done with a custom LogMessageImpl in hexagon_common.cc. This ends up calling HexagonLog and HEXAGON_PRINT which uses the HAP FARF API. Unfortunately, the TVM log level is lost along the way, with logs being produced at FARF’s ALWAYS level. This becomes especially noisy with RPC debug logging, which generates enough noise to cause some log data to be dropped. It also introduces a lot of useless noise, as the FARF API produces its own line number information, which only points to where hexagon_common.cc calls HEXAGON_PRINT. Using the HAP_debug_v2 API lets us pass the log level and file line information directly, and enables runtime selection of logging levels. This commit explicity passes the log level to LogMessage/LogMessageImpl and updates Hexagon's custom LogMessageImpl to use the HAP_debug_v2 API.
supersat
force-pushed
the
improve-hexagon-logging
branch
from
41b1717 to
fe1c5ba
Compare
|
@supersat LGTM! I started a job on hardware. Will merge after that finishes |
mehrdadh
approved these changes
Oct 28, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 10, 2022
* [Logging][Hexagon] Improve logging on Hexagon Currently Hexagon logging is done with a custom LogMessageImpl in hexagon_common.cc. This ends up calling HexagonLog and HEXAGON_PRINT which uses the HAP FARF API. Unfortunately, the TVM log level is lost along the way, with logs being produced at FARF’s ALWAYS level. This becomes especially noisy with RPC debug logging, which generates enough noise to cause some log data to be dropped. It also introduces a lot of useless noise, as the FARF API produces its own line number information, which only points to where hexagon_common.cc calls HEXAGON_PRINT. Using the HAP_debug_v2 API lets us pass the log level and file line information directly, and enables runtime selection of logging levels. This commit explicity passes the log level to LogMessage/LogMessageImpl and updates Hexagon's custom LogMessageImpl to use the HAP_debug_v2 API. * Adjust Hexagon rpc_server logging to use the DEBUG level * Update hexagon_api launcher script to omit DEBUG-level logs * Update WASM LogMessageImpl to accept explicit level * Update Android LogMessageImpl to accept and forward explicit log level * Move LogMessage::level_strings_ out of some ifdefs * Update iOS LogMessageImpl to accept explicit log level * Attempt to fix Windows build * Add comments about runtime hexagon log level encodings * Remove unneeded string processing in LogMessage * Remove TODO * Update HexagonLauncherAndroid to accept runtime log filtering configuration
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [Logging][Hexagon] Improve logging on Hexagon Currently Hexagon logging is done with a custom LogMessageImpl in hexagon_common.cc. This ends up calling HexagonLog and HEXAGON_PRINT which uses the HAP FARF API. Unfortunately, the TVM log level is lost along the way, with logs being produced at FARF’s ALWAYS level. This becomes especially noisy with RPC debug logging, which generates enough noise to cause some log data to be dropped. It also introduces a lot of useless noise, as the FARF API produces its own line number information, which only points to where hexagon_common.cc calls HEXAGON_PRINT. Using the HAP_debug_v2 API lets us pass the log level and file line information directly, and enables runtime selection of logging levels. This commit explicity passes the log level to LogMessage/LogMessageImpl and updates Hexagon's custom LogMessageImpl to use the HAP_debug_v2 API. * Adjust Hexagon rpc_server logging to use the DEBUG level * Update hexagon_api launcher script to omit DEBUG-level logs * Update WASM LogMessageImpl to accept explicit level * Update Android LogMessageImpl to accept and forward explicit log level * Move LogMessage::level_strings_ out of some ifdefs * Update iOS LogMessageImpl to accept explicit log level * Attempt to fix Windows build * Add comments about runtime hexagon log level encodings * Remove unneeded string processing in LogMessage * Remove TODO * Update HexagonLauncherAndroid to accept runtime log filtering configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Hexagon logging is done with a custom
LogMessageImplinhexagon_common.cc. This ends up callingHexagonLogandHEXAGON_PRINTwhich uses the HAP FARF API. Unfortunately, the TVM log level is lost along the way, with logs being produced at FARF’sALWAYSlevel. This becomes especially noisy with RPC debug logging, which generates enough noise to cause some log data to be dropped. It also introduces a lot of useless noise, as the FARF API produces its own line number information, which only points to wherehexagon_common.cccallsHEXAGON_PRINT. Using theHAP_debug_runtimeAPI lets us pass the log level and file line information directly, and enables runtime selection of logging levels.This commit explicitly passes the log level to
LogMessage/LogMessageImpland updates Hexagon's customLogMessageImplto use theHAP_debug_runtimeAPI.