-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] fix python setup.py file bug #12000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhengqiang Yin <[email protected]>
I'm a little confused about choosing the corresponding reviewers for this PR. I'm sorry if this mention disturbed you, and please help me correct it. Thanks a lot. |
leandron
reviewed
Jul 4, 2022
leandron
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once passes CI, happy for this to be merged.
driazati
pushed a commit
that referenced
this pull request
Jul 12, 2022
* fix setup.py bug Signed-off-by: Zhengqiang Yin <[email protected]> * remove data_files field * keep a init setup_kwargs
driazati
pushed a commit
that referenced
this pull request
Jul 12, 2022
* fix setup.py bug Signed-off-by: Zhengqiang Yin <[email protected]> * remove data_files field * keep a init setup_kwargs
driazati
pushed a commit
that referenced
this pull request
Jul 12, 2022
* fix setup.py bug Signed-off-by: Zhengqiang Yin <[email protected]> * remove data_files field * keep a init setup_kwargs
driazati
pushed a commit
that referenced
this pull request
Jul 12, 2022
* fix setup.py bug Signed-off-by: Zhengqiang Yin <[email protected]> * remove data_files field * keep a init setup_kwargs
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* fix setup.py bug Signed-off-by: Zhengqiang Yin <[email protected]> * remove data_files field * keep a init setup_kwargs
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* fix setup.py bug Signed-off-by: Zhengqiang Yin <[email protected]> * remove data_files field * keep a init setup_kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhengqiang Yin [email protected]
The
data_files
filed insetup_kwargs
seems only allow file path rather than dir path. I try to useos.walk
to find all the files and re-set them to thedata_files
filed. This works fine for me and someone else.Related issue is : #11726