Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] int32/64 mismatch of buffer elem_offset at HandleBufferBindScope #11755

Merged
merged 10 commits into from
Jun 22, 2022

Conversation

ganler
Copy link
Contributor

@ganler ganler commented Jun 16, 2022

Yet another int64/32 mismatch at TIR level. ArgBinder::Bind_ requires elem_offset of arg & view to have the same dtype while int64-broadcast-concat produce int64 elem_offset. cc: @masahi

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganler
Copy link
Contributor Author

ganler commented Jun 17, 2022

Oh i should have check .defined() first.

@ganler
Copy link
Contributor Author

ganler commented Jun 22, 2022

@junrushao1994 Eventually passed the CI. Sorry for the latency.

@junrushao junrushao merged commit c334790 into apache:main Jun 22, 2022
@junrushao
Copy link
Member

Thanks!! @ganler

blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
apache#11755)

Yet another int64/32 mismatch at TIR level. `ArgBinder::Bind_` requires `elem_offset` of arg & view to have the same dtype while `int64-broadcast-concat` produce int64 `elem_offset`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants