-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Default option is not passed by TVMC Front end #13264
Labels
needs-triage
PRs or issues that need to be investigated by maintainers to find the right assignees to address it
type: bug
Comments
MNGanesan
added
needs-triage
PRs or issues that need to be investigated by maintainers to find the right assignees to address it
type: bug
labels
Nov 2, 2022
MNGanesan
pushed a commit
to MNGanesan/tvm
that referenced
this issue
May 21, 2024
) BYOC Compiler's Config node defines the target compiler's command line options, along with default values. This change extract the default values from config node, while constructing target options for codegen/target compiler. Added test case for this feature as well. Signed-off-by: M N Ganesan <[email protected]>
MNGanesan
pushed a commit
to MNGanesan/tvm
that referenced
this issue
Jun 10, 2024
) BYOC Compiler's Config node defines the target compiler's command line options, along with default values. This change extract the default values from config node, while constructing target options for codegen/target compiler. Added test case for this feature as well. Signed-off-by: M N Ganesan <[email protected]>
Hzfengsy
pushed a commit
that referenced
this issue
Jun 26, 2024
…17014) * [Frontend][ArgParse] Pass default values to target compiler(#13264) BYOC Compiler's Config node defines the target compiler's command line options, along with default values. This change extract the default values from config node, while constructing target options for codegen/target compiler. Added test case for this feature as well. Signed-off-by: M N Ganesan <[email protected]> * [Frontend][ArgParse] Pass default values to target compiler(#13264) BYOC Compiler's Config node defines the target compiler's command line options, along with default values. This change extract the default values from config node, while constructing target options for codegen/target compiler. Added test case for this feature as well. Signed-off-by: M N Ganesan <[email protected]> * Lint Fix Signed-off-by: M N Ganesan <[email protected]> --------- Signed-off-by: M N Ganesan <[email protected]> Co-authored-by: M N Ganesan <[email protected]>
#17014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-triage
PRs or issues that need to be investigated by maintainers to find the right assignees to address it
type: bug
Under Hybrid Target, I have created target specific config or compiler options in the backend(codegen), These option are given with default values too.
Example:
TVM_ROOT/src/relay/backend/contrib/my_target/codegen.cc
struct MyCompilerConfigNode : public tvm::AttrsNode {
String mcpu;
TVM_DECLARE_ATTRS(MyCompilerConfigNode, "ext.attrs.MyCompilerConfigNode") {
TVM_ATTR_FIELD(mcpu)
.describe("CPU type")
.set_default("my_cpu"); <=========
}
};
In the TVMC , I try to access those options under the partition_for_target function
TVM_ROOT/relay/op/contrib/target.py
However, the default values given to these options are not visible.
I doubt TVMC is not handling or honoring the default values for options.
I have no clue if it works for other hybrid target like cmsis-nn or vitis-ai ? Could some put light on this ?
Expected behavior
What you were expecting
Actual behavior
Am expecting the default values for any command line options described in the codegen.cc
Environment
Any environment details, such as: Operating System, TVM version, etc
Steps to reproduce
Preferably a minimal script to cause the issue to occur.
Triage
Please refer to the list of label tags here to find the relevant tags and add them below in a bullet format (example below).
The text was updated successfully, but these errors were encountered: