Revert "lib: cpp: TTransportException: create thrift::numeric_cast" #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meric_cast" This reverts commit 6e9cbbd. See https://issues.apache.org/jira/browse/THRIFT-5660 for a discussion.
emmenlau
force-pushed
the
emmenlau_revert_breaking_cast
branch
from
f62c17d to
49e4cea
Compare
|
According to https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48277648/job/ri9oqkbvar4mrw6l and https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/48277648/job/a7ijfy2ou2jn3fct there are no new build or test errors triggered by this PR. Merging, because the change reverts to an older state that was well tested. |
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6e9cbbd. Sadly, the implementation of
apache::thrift::numeric_cast()breaks theHEADERprotocol in the C++ implementation. Reverting this commit fixes the breakage.See for a discussion.
[skip ci]anywhere in the commit message to free up build resources.