Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5569: add negative size checks in Go generator when reading maps, sets and lists #2582

Merged
merged 1 commit into from
Apr 20, 2022
Merged

THRIFT-5569: add negative size checks in Go generator when reading maps, sets and lists #2582

merged 1 commit into from
Apr 20, 2022

Conversation

akrennmair
Copy link
Contributor

This adds a negative size checks in the Go generator for code generated when reading maps, sets and lists.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G merged commit 8987820 into apache:master Apr 20, 2022
@akrennmair akrennmair deleted the add-negative-size-checks branch April 21, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants