[logging] deprecation notices for SQLite #9662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
reviewed
Apr 27, 2020
|
Thank you @etr2460. It seems like logging.warn() has been deprecated for Python 3.4+, will use |
etr2460
approved these changes
Apr 27, 2020
willbarrett
reviewed
Apr 27, 2020
superset/migrations/env.py
Outdated
| config.set_main_option("sqlalchemy.url", current_app.config["SQLALCHEMY_DATABASE_URI"]) | ||
| DATABASE_URI = current_app.config["SQLALCHEMY_DATABASE_URI"] | ||
| if "sqlite" in DATABASE_URI: | ||
| logger.warning("SQLite DB support may not be supported by in future version") |
There was a problem hiding this comment.
Grammar nit: could we use "SQLite Database support for metadata databases will be removed in a future version of Superset."
willbarrett
approved these changes
Apr 27, 2020
lilykuang
force-pushed
the
lily/feature/deprecation-notices-SQLite
branch
from
8246607 to
f5c5695
Compare
lilykuang
force-pushed
the
lily/feature/deprecation-notices-SQLite
branch
from
f5c5695 to
86e5cfe
Compare
Codecov Report
@@ Coverage Diff @@
## master #9662 +/- ##
=======================================
Coverage 70.53% 70.53%
=======================================
Files 574 581 +7
Lines 30152 30222 +70
Branches 3066 3072 +6
=======================================
+ Hits 21267 21317 +50
- Misses 8774 8794 +20
Partials 111 111
Continue to review full report at Codecov.
|
villebro
approved these changes
Apr 28, 2020
craig-rueda
approved these changes
Apr 28, 2020
… lily/feature/deprecation-notices-SQLite
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Support for SQLite as a metadata database will be officially removed. SQLite may still be usable, but it will not be supported in future Alembic migrations. This PR is following step 1 on Immediate: plans from [SIP-33] #8874
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@willbarrett