-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Duplicate Tab
option
#8485
Add Duplicate Tab
option
#8485
Conversation
Adds an option to duplicate the current tab's setting/content into a new tab. Useful if you're iterating on a query.
Codecov Report
@@ Coverage Diff @@
## master #8485 +/- ##
==========================================
- Coverage 71.47% 66.53% -4.94%
==========================================
Files 117 449 +332
Lines 12336 22603 +10267
Branches 0 2367 +2367
==========================================
+ Hits 8817 15039 +6222
- Misses 3519 7426 +3907
- Partials 0 138 +138
Continue to review full report at Codecov.
|
There have been conversations about removing tabs altogether in Apart from that this PR LGTM |
Yeah I permanently seem to have >30 tabs open but I'd like to be able to group them into different "projects" and maybe have one project per browser tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm, thanks for the feature addition!
We'll also improve naming / saving / autosaving queries to help with that as we deprecate tabs. You could also use browser windows as sets of browser tabs or "projects" if needed. |
CATEGORY
Adds an option to duplicate the current tab's setting/content into a new tab. Useful if you're iterating on a query.
Choose one
SUMMARY
This adds a
Duplicate Tab
option.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
New option:
TEST PLAN
Open a tab, selected the "options" chevron, click on
Duplicate Tab
.Verify the new tab's settings (database and schema selections) and SQL query match the previous tab's
Verify the title is
Copy of <previous tab title>
ADDITIONAL INFORMATION
REVIEWERS