Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Duplicate Tab option #8485

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Add Duplicate Tab option #8485

merged 2 commits into from
Nov 4, 2019

Conversation

paulvic
Copy link
Contributor

@paulvic paulvic commented Oct 30, 2019

CATEGORY

Adds an option to duplicate the current tab's setting/content into a new tab. Useful if you're iterating on a query.

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This adds a Duplicate Tab option.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

New option:
image

Superset_DuplicateTabs

TEST PLAN

Open a tab, selected the "options" chevron, click on Duplicate Tab.
Verify the new tab's settings (database and schema selections) and SQL query match the previous tab's
Verify the title is Copy of <previous tab title>

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

Adds an option to duplicate the current tab's setting/content into a new tab. Useful if you're iterating on a query.
@paulvic paulvic changed the title Add Duplicate Tab option [WIP] Add Duplicate Tab option Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #8485 into master will decrease coverage by 4.93%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8485      +/-   ##
==========================================
- Coverage   71.47%   66.53%   -4.94%     
==========================================
  Files         117      449     +332     
  Lines       12336    22603   +10267     
  Branches        0     2367    +2367     
==========================================
+ Hits         8817    15039    +6222     
- Misses       3519     7426    +3907     
- Partials        0      138     +138
Impacted Files Coverage Δ
.../assets/src/SqlLab/components/TabbedSqlEditors.jsx 83.03% <75%> (ø)
...sets/src/explore/components/ExploreChartHeader.jsx 50% <0%> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...perset/assets/src/dashboard/util/getEmptyLayout.js 0% <0%> (ø)
...ts/src/dashboard/util/getComponentWidthFromDrop.js 95.23% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.23% <0%> (ø)
...rc/explore/components/controls/AnnotationLayer.jsx 2.46% <0%> (ø)
superset/assets/src/welcome/DashboardTable.jsx 87.5% <0%> (ø)
...erset/assets/src/dashboard/util/injectCustomCss.js 91.66% <0%> (ø)
...explore/components/controls/ColorPickerControl.jsx 85% <0%> (ø)
... and 323 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cba1bd...ae6576b. Read the comment docs.

@paulvic paulvic changed the title [WIP] Add Duplicate Tab option Add Duplicate Tab option Oct 30, 2019
@mistercrunch
Copy link
Member

There have been conversations about removing tabs altogether in SQL Lab and let users use normal browsers tabs instead.

Apart from that this PR LGTM

@paulvic
Copy link
Contributor Author

paulvic commented Oct 31, 2019

There have been conversations about removing tabs altogether in SQL Lab and let users use normal browsers tabs instead.

Apart from that this PR LGTM

Yeah I permanently seem to have >30 tabs open but I'd like to be able to group them into different "projects" and maybe have one project per browser tab.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, thanks for the feature addition!

@etr2460 etr2460 merged commit 5df1fcb into apache:master Nov 4, 2019
@mistercrunch
Copy link
Member

We'll also improve naming / saving / autosaving queries to help with that as we deprecate tabs. You could also use browser windows as sets of browser tabs or "projects" if needed.

graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
* Add `Duplicate Tab` option

Adds an option to duplicate the current tab's setting/content into a new tab. Useful if you're iterating on a query.

* Add test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants