Event logger config takes instance instead of class #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiggidyDave
changed the title
|
Side note: Try running |
betodealmeida
requested changes
Aug 8, 2019
superset/utils/log.py
Outdated
| """ | ||
| result: Any = cfg_value | ||
| if inspect.isclass(cfg_value): | ||
| logging.getLogger().warning( |
There was a problem hiding this comment.
We could also use https://docs.python.org/3/library/exceptions.html#DeprecationWarning here. TBH I'm not super familiar with the difference or the best approach.
There was a problem hiding this comment.
I feel like this is probably a more "correct" approach, but I tried to use warnings.warn(msg, DeprecationWarning) and didn't see any message locally. I'm sure it can be configured, but I wanted to be sure that this would be seen.
There was a problem hiding this comment.
Other than this one (which I am open to, but it seems... extra) I implemented all of your suggestions @betodealmeida
|
@dpgaspar one more ping |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Deprecate EVENT_LOGGER assignment of class type in favor of instance. Deprecation is handled gracefully and only outputs a WARNING log message at config load time. We have a need to configure an impl of AbstractEventLogger which is instantiated/pre-configured with some proprietary dependencies.
This change is a small refactor on top of the nice change #7705 @dpgaspar made a few weeks ago.
TEST PLAN
Unit tests added, and tested manually.
ADDITIONAL INFORMATION
REVIEWERS
@dpgaspar @john-bodley @graceguo-supercat @mistercrunch