Allowing withVerification to remove all options if none are valid

[michellethomas]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Previously, I was only allowing options to be filtered if there were existing validOptions, but it was preventing filtering out all options if none are valid.

TEST PLAN

Set up control overrides to use one of the controls using withVerification
Call a getEndpoint with no valid options
Confirm that no options show up in the dropdown

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@kristw @graceguo-supercat

[codecov-io]

Codecov Report

Merging #7652 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #7652   +/-   ##
=======================================
  Coverage   65.57%   65.57%           
=======================================
  Files         435      435           
  Lines       21754    21754           
  Branches     2394     2394           
=======================================
  Hits        14266    14266           
  Misses       7367     7367           
  Partials      121      121

Impacted Files	Coverage Δ
...c/explore/components/controls/withVerification.jsx	96.77% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd0e7f...ce82c97. Read the comment docs.

[michellethomas]

ping @kristw @graceguo-supercat

[mistercrunch]

LGTM