[ad-hoc] Fixing type for COUNT DISTINCT #7573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7573 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 433 433
Lines 21428 21428
Branches 2360 2360
=======================================
Hits 13966 13966
Misses 7342 7342
Partials 120 120
Continue to review full report at Codecov.
|
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jul 11, 2019
(cherry picked from commit 6b9790c)
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 11, 2019
[ad-hoc] Fixing type for count distinct (apache#7573)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR fixes an issue with ad-hoc metrics using the Druid REST API related to
COUNT DISTINCT. Specifically per the documentation the type should behyperUniquewhenas opposed to
cardinality. Both use HyperLogLog however the former is specific to Druid metrics which are of typehyperUnique(per the indexing aggregation) vs computing the cardinality of non-complex types.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI.
REVIEWERS
to: @gabe-lyons @michellethomas @mistercrunch