-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce db queries in /queries/ endpoint #7498
Merged
graceguo-supercat
merged 1 commit into
apache:master
from
graceguo-supercat:gg-Revert#4833
May 24, 2019
Merged
Reduce db queries in /queries/ endpoint #7498
graceguo-supercat
merged 1 commit into
apache:master
from
graceguo-supercat:gg-Revert#4833
May 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
john-bodley
approved these changes
May 14, 2019
cc4649c
to
b2e22ba
Compare
b2e22ba
to
70c0868
Compare
Codecov Report
@@ Coverage Diff @@
## master #7498 +/- ##
=========================================
- Coverage 65.2% 65.2% -0.01%
=========================================
Files 435 435
Lines 21486 21477 -9
Branches 2378 2378
=========================================
- Hits 14011 14005 -6
+ Misses 7355 7352 -3
Partials 120 120
Continue to review full report at Codecov.
|
john-bodley
pushed a commit
that referenced
this pull request
May 24, 2019
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 31, 2019
(cherry picked from commit 2014329)
michellethomas
pushed a commit
that referenced
this pull request
Jun 1, 2019
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 03cae41)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 2014329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
!deprecated-label:bug
Deprecated label - Use #bug instead
size/M
🚢 0.34.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
In #4833, we tried to introduce a feature that setting old async query status to be timed_out, when the query status stuck at pending or running after 6 hours. This status update will help front-end (browser) not fetching very old query status. But i found that backend actually didn't commit transaction, so the whole query/update logic seems no use.
In #7429 I was trying to fix this issue by adding db commit. But I also found in front-end javascript, we have logic that don't poll query status after
SQLLAB_ASYNC_TIME_LIMIT_SEC
reached. I feel the additional query/update in backend every second, seems expensive and not necessary. So I propose to remove this query/update logic from every polling request.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
TEST PLAN
CI and watch query polling.
ADDITIONAL INFORMATION
REVIEWERS
@john-bodley @timifasubaa @mistercrunch @michellethomas