Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL Lab] Adds autocomplete on table names and auto-add to schema bro… #7130

Closed
wants to merge 2 commits into from
Closed

[SQL Lab] Adds autocomplete on table names and auto-add to schema bro… #7130

wants to merge 2 commits into from

Conversation

enricoberti
Copy link
Contributor

…wser

Closes #7059

@enricoberti
Copy link
Contributor Author

20190326_autocomplete 2019-03-26 16_38_00

@kristw kristw added the enhancement:request Enhancement request submitted by anyone from the community label Mar 27, 2019
@kristw
Copy link
Contributor

kristw commented Mar 27, 2019

CI is failing.

@vylc vylc added the lyft Related to Lyft label Mar 28, 2019
@enricoberti
Copy link
Contributor Author

@kristw mmm, all the ones that fail they do with "ERROR: could not install deps", so i'm not sure it's related to the commit.

@mistercrunch
Copy link
Member

You'll have to rebase your branch. This issue was around a Python dependency that went missing.

@mistercrunch
Copy link
Member

Can you please add some unit tests to make sure coverage goes up upon landing this? The coverage report should appear when the build goes through after fixing the python lint issues.

@codecov-io
Copy link

codecov-io commented Apr 1, 2019 •
edited
Loading

Codecov Report

Merging #7130 into master will decrease coverage by 0.02%.
The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7130      +/-   ##
==========================================
- Coverage   65.59%   65.56%   -0.03%     
==========================================
  Files         435      435              
  Lines       21694    21723      +29     
  Branches     2387     2392       +5     
==========================================
+ Hits        14230    14243      +13     
- Misses       7343     7359      +16     
  Partials      121      121
Impacted Files Coverage Δ
...uperset/assets/src/SqlLab/components/SqlEditor.jsx 54.03% <ø> (ø) ⬆️
superset/assets/src/SqlLab/reducers/sqlLab.js 48.38% <0%> (-1.07%) ⬇️
superset/assets/src/components/TableSelector.jsx 84.67% <100%> (+0.51%) ⬆️
.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx 39.62% <33.33%> (-0.81%) ⬇️
superset/assets/src/SqlLab/actions/sqlLab.js 63.4% <33.33%> (-0.79%) ⬇️
.../assets/src/SqlLab/components/AceEditorWrapper.jsx 58.02% <50%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722043c...468d711. Read the comment docs.

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 31, 2019
@stale stale bot removed the inactive Inactive for >= 30 days label Jun 1, 2019
mistercrunch added a commit to mistercrunch/superset that referenced this pull request Jun 1, 2019
@mistercrunch
Wrapping up apache#7130
2c95d86 
For more details see apache#7130, this PR addresses the merge conflicts.
@mistercrunch mistercrunch mentioned this pull request Jun 1, 2019
Merged
@mistercrunch
Copy link
Member

Superseded by #7633, closing

mistercrunch added a commit that referenced this pull request Jun 1, 2019
@mistercrunch
Wrapping up #7130 (#7633)
687f205 
* [SQL Lab] Adds autocomplete on table names and auto-add to schema browser

Closes #7059

* Wrapping up #7130

For more details see #7130, this PR addresses the merge conflicts.
mistercrunch added a commit to mistercrunch/superset that referenced this pull request Jul 27, 2019
@mistercrunch
Fix apache#7130 - SQL Lab table name autocomplete
6af5bf2
mistercrunch added a commit that referenced this pull request Jul 28, 2019
@mistercrunch
Fix #7130 - SQL Lab table name autocomplete (#7926)
5f98d66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community lyft Related to Lyft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SQL Lab] autocomplete table names, auto-add to schema browser
5 participants
@enricoberti @kristw @mistercrunch @codecov-io @vylc