[tests] fix sqllab/TableElement_spec #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conglei
approved these changes
Sep 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #5874 +/- ##
=======================================
Coverage 63.73% 63.73%
=======================================
Files 374 374
Lines 23328 23328
Branches 2608 2608
=======================================
Hits 14869 14869
Misses 8446 8446
Partials 13 13Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #5874 +/- ##
=======================================
Coverage 63.73% 63.73%
=======================================
Files 374 374
Lines 23328 23328
Branches 2608 2608
=======================================
Hits 14869 14869
Misses 8446 8446
Partials 13 13Continue to review full report at Codecov.
|
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 12, 2018
(cherry picked from commit bec0b4c)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a JS test that I encountered locally and seems to be failing others (e.g., failed build here from #5865, #5869, etc.)
I'm not sure how this test passed before TBH. According to git blame
removeDataPreview(notremoveTable) has been called for ~2 years. My only thought is that this async test didn't properly call thedone()callback, so maybe it was getting skipped most of the time 🤔@mistercrunch @kristw @conglei @graceguo-supercat @michellethomas