Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] 'an error has ooccured' when saving datasource #5683

Merged
merged 1 commit into from
Aug 21, 2018
Merged

[bug] 'an error has ooccured' when saving datasource #5683

merged 1 commit into from
Aug 21, 2018

Conversation

mistercrunch
Copy link
Member

The check_ownership was failing when Alpha user was saving a datasource
from the datasource editor.

@mistercrunch
[bug] 'an error has ooccured' when saving datasource
14b3165 
The check_ownership was failing when Alpha user was saving a datasource
from the datasource editor.
@codecov-io
Copy link

Codecov Report

Merging #5683 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5683      +/-   ##
==========================================
+ Coverage   63.49%   63.49%   +<.01%     
==========================================
  Files         360      360              
  Lines       22910    22912       +2     
  Branches     2551     2551              
==========================================
+ Hits        14547    14549       +2     
  Misses       8348     8348              
  Partials       15       15
Impacted Files Coverage Δ
superset/views/base.py 68% <100%> (ø) ⬆️
superset/views/datasource.py 96.66% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d23ae1...14b3165. Read the comment docs.

@hughhhh hughhhh self-requested a review August 21, 2018 06:46
hughhhh
hughhhh approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mistercrunch mistercrunch merged commit 50042af into apache:master Aug 21, 2018
@mistercrunch mistercrunch deleted the fix_save_datasource branch August 21, 2018 17:10
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
[bug] 'an error has ooccured' when saving datasource (apache#5683)
aea25f0 
The check_ownership was failing when Alpha user was saving a datasource
from the datasource editor.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
@matrix-compute matrix-compute mentioned this pull request Oct 9, 2024
Open
This was referenced Oct 10, 2024
Open
Open
@DanyRay420 DanyRay420 mentioned this pull request Oct 10, 2024
Open
@xiezhongfu xiezhongfu mentioned this pull request Oct 11, 2024
Open
@swtnk swtnk mentioned this pull request Oct 13, 2024
Open
@Aviking88 Aviking88 mentioned this pull request Oct 14, 2024
Open
@yannhowe yannhowe mentioned this pull request Oct 14, 2024
Open
@choupijiang choupijiang mentioned this pull request Oct 14, 2024
Open
@Carolinewly Carolinewly mentioned this pull request Oct 15, 2024
Open
@Antibioticvz Antibioticvz mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @codecov-io @hughhhh