fix migration 3dda56f1c #5468
Merged
fix migration 3dda56f1c #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5468 +/- ##
=======================================
Coverage 59.11% 59.11%
=======================================
Files 372 372
Lines 23751 23751
Branches 2758 2758
=======================================
Hits 14041 14041
Misses 9695 9695
Partials 15 15Continue to review full report at Codecov.
|
| @@ -17,6 +17,7 @@ geopy==1.11.0 | |||
| gunicorn==19.8.0 | |||
| humanize==0.5.1 | |||
| idna==2.6 | |||
| isodate==0.6.0 | |||
There was a problem hiding this comment.
when we try cherry-pick #5177, we got No module named isodate
| @@ -75,6 +75,7 @@ def get_git_sha(): | |||
| 'gunicorn', # deprecated | |||
| 'humanize', | |||
| 'idna', | |||
| 'isodate', | |||
There was a problem hiding this comment.
Migration line 109
john-bodley
approved these changes
Jul 23, 2018
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* fix migration 3dda56f1c * add isodate to setup.py:
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jul 26, 2018
* fix migration 3dda56f1c * add isodate to setup.py: (cherry picked from commit bea0a0a)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* fix migration 3dda56f1c * add isodate to setup.py:
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with slices that have no params and pass None to be decoded by json.loads.
@betodealmeida @graceguo-supercat @mistercrunch @john-bodley