Migrate dashboard positions data from v1 to v2 format #5463
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5463 +/- ##
=======================================
Coverage 59.11% 59.11%
=======================================
Files 372 372
Lines 23751 23751
Branches 2758 2758
=======================================
Hits 14041 14041
Misses 9695 9695
Partials 15 15Continue to review full report at Codecov.
|
graceguo-supercat
force-pushed
the
gg-MigrateV1Dashboard
branch
2 times, most recently
from
9ae941c to
b37a3ab
Compare
|
this lgtm for the conversion, could one of @mistercrunch @john-bodley @michellethomas or @timifasubaa PTAL at the python / migration specifics? |
|
I'd recommend adding a note in |
graceguo-supercat
force-pushed
the
gg-MigrateV1Dashboard
branch
2 times, most recently
from
812f692 to
c893de6
Compare
There was a problem hiding this comment.
sounds like this all executed successfully in staging with @john-bodley 's migration fix in, so approving this one too 🔥
graceguo-supercat
force-pushed
the
gg-MigrateV1Dashboard
branch
from
c893de6 to
06ff600
Compare
* Migrate dashboard positions data from v1 to v2 format * UPDATING.md * rebase onto master (cherry picked from commit fd2d4b0)
* Migrate dashboard positions data from v1 to v2 format * UPDATING.md * rebase onto master
mistercrunch
added
🏷️ bot
This PR blocks #5418.
This work was implemented in frontend js, we show dashboard v2 in preview mode, but not save the converted format to dashboard table.
Here we provide automatic migration script, to convert all not converted dashboard position_json data from V1 array to V2 nested layout.
js code is here:
https://github.com/apache/incubator-superset/blob/master/superset/assets/src/dashboard/util/dashboardLayoutConverter.js
@john-bodley @mistercrunch @timifasubaa @michellethomas @williaster