Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Not Grouped By on Table View #544

Merged
merged 3 commits into from
Jun 2, 2016

Conversation

georgeke
Copy link
Contributor

@georgeke georgeke commented Jun 1, 2016

Remove the default metrics field on Table View since using the Not Grouped By field requires the metrics field to be empty. This would cause a Choose either fields to [Group By] and [Metrics] or [Columns], not both error.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage increased (+0.02%) to 82.127% when pulling fcc9bde on georgeke:not-grouped-by into 087c47a on airbnb:master.

@mistercrunch
Copy link
Member

Let's handle all cases here (label and description as well) and remove that logic from the templates if that's possible.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 81.942% when pulling 73bafbf on georgeke:not-grouped-by into 087c47a on airbnb:master.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.01%) to 82.095% when pulling 14c8729 on georgeke:not-grouped-by into 087c47a on airbnb:master.

@mistercrunch
Copy link
Member

img

@mistercrunch mistercrunch merged commit cb384d0 into apache:master Jun 2, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants