Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin kombu dependency #5150

Merged
merged 1 commit into from
Jun 6, 2018
Merged

pin kombu dependency #5150

merged 1 commit into from
Jun 6, 2018

Conversation

timifasubaa
Copy link
Contributor

@timifasubaa timifasubaa commented Jun 6, 2018 •
edited
Loading

CI is failing (https://travis-ci.org/apache/incubator-superset/jobs/388955214#L730) because the latest kombu (4.2) is backwards incompatible and we didn't pin it. This PR fixes that by pining

@williaster @john-bodley

@williaster williaster mentioned this pull request Jun 6, 2018
Merged
2 tasks
@codecov-io
Copy link

codecov-io commented Jun 6, 2018 •
edited
Loading

Codecov Report

Merging #5150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5150   +/-   ##
=======================================
  Coverage   77.48%   77.48%           
=======================================
  Files          44       44           
  Lines        8737     8737           
=======================================
  Hits         6770     6770           
  Misses       1967     1967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f102eab...5d37ef3. Read the comment docs.

@williaster
Copy link
Contributor

LGTM

@williaster williaster merged commit 0abbc98 into master Jun 6, 2018
@john-bodley
Copy link
Member

john-bodley commented Jun 7, 2018 •
edited
Loading

@timifasubaa could you please also add this dependency to setup.py. Also we should track when the Celery/Kombo issue has been resolved and bump the Celery version when appropriate thus removing the need to pin Kombo.

mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jun 7, 2018
@timifasubaa @mistercrunch
pin kombu dependency (apache#5150)
a783535 
(cherry picked from commit 0abbc98)
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jun 27, 2018
@timifasubaa @hughhhh
pin kombu dependency (apache#5150)
40f9010 
(cherry picked from commit 0abbc98)
timifasubaa added a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@timifasubaa
pin kombu dependency (apache#5150)
d9e276d
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@timifasubaa @williaster
pin kombu dependency (apache#5150)
8ac34da
@kristw kristw deleted the timi-pin-kombu-dependency branch March 6, 2019 16:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timifasubaa @codecov-io @williaster @john-bodley @mistercrunch