Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WorldMap] Add required parameter validation #4922

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented May 2, 2018

screen_shot_2018-05-02_at_3_25_08_pm-3

If user didn't set bubble size, chart will throw confusing error message.

@michellethomas @mistercrunch

@codecov-io
Copy link

Codecov Report

Merging #4922 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4922   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files          44       44           
  Lines        8539     8539           
=======================================
  Hits         6586     6586           
  Misses       1953     1953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e213ccd...a702eef. Read the comment docs.

Copy link
Contributor

@michellethomas michellethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find!

@mistercrunch
Copy link
Member

The original intent was to make this optional though, we didn't want to force the user to layer a bubble on top of the color area

@mistercrunch
Copy link
Member

The fix probably should be to make the metric optional on the backend

@graceguo-supercat
Copy link
Author

yeah, i am thinking about this could be optional parameter.
Here:
qry['metrics'] = [
self.form_data['metric'], self.form_data['secondary_metric']]

I don't know what's the best way to fallback a default value? Otherwise it will append None into metrics array

@mistercrunch
Copy link
Member

The changes on MetricsControl introduced some issues I'm addressing here: #4914

@graceguo-supercat
Copy link
Author

ok I will close this PR and just verify World Map viz after you merged #4914.

@graceguo-supercat graceguo-supercat deleted the gg-FixWorldMapVizControl branch May 3, 2018 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants