Disable user access request #4405
Merged
+258
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
disable_user_access_request
branch
2 times, most recently
from
123335b to
117db38
Compare
timifasubaa
force-pushed
the
disable_user_access_request
branch
from
117db38 to
5f3862b
Compare
|
You may want to disable the ModelView as well |
|
@mistercrunch Done. I left the access requests on by default. Is it better off by default? |
timifasubaa
force-pushed
the
disable_user_access_request
branch
from
d94539c to
63a7cdf
Compare
|
Let's flip it off by default. |
timifasubaa
force-pushed
the
disable_user_access_request
branch
from
63a7cdf to
410e764
Compare
|
Done |
timifasubaa
force-pushed
the
disable_user_access_request
branch
4 times, most recently
from
4ff61ea to
fb24089
Compare
|
Wait you're deleting all those tests :( Why not just have them look at the same config/feature flag? |
|
Ah, true. I'll do it that way instead. |
timifasubaa
force-pushed
the
disable_user_access_request
branch
3 times, most recently
from
ccc1b05 to
5550e58
Compare
timifasubaa
force-pushed
the
disable_user_access_request
branch
from
5550e58 to
c4c21a2
Compare
|
Do you have idea how does it join with #4352 ? |
|
@maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change whether gamma has access to dashboards it created. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* add feature flag to config * wrap check around a feature flag * add flag to the model view * remove access request from seurity tests
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* add feature flag to config * wrap check around a feature flag * add flag to the model view * remove access request from seurity tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request access feature isn't fully implemented and it can potentially be misleading to users who click the access request button and expect to gain access eventually. This PR makes the access request button optional via a feature flag that allows it by default.
If you set the flag to false, you'll no longer see the image below whenever you don't have access to any of the slices in a dashboard.
Instead, you'll see all the slices and an error message for any one you don't have access to. Like in the image below.
@john-bodley @michellethomas @mistercrunch