Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional postgres and redshift time grains #429

Merged
merged 1 commit into from
May 3, 2016

Conversation

itajaja
Copy link
Contributor

@itajaja itajaja commented May 3, 2016

redshift docs: http://docs.aws.amazon.com/redshift/latest/dg/r_Dateparts_for_datetime_functions.html
postgres docs: http://www.postgresql.org/docs/9.1/static/functions-datetime.html

Not sure if it's sensible to test this.
"I tried it and it works" gave 100% coverage for this :D

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 0d44bd9 on itajaja:additional-pg-grains into 88c9516 on airbnb:master.

@coveralls
Copy link

coveralls commented May 3, 2016

Coverage Status

Coverage remained the same at 80.869% when pulling 0d44bd9 on itajaja:additional-pg-grains into 88c9516 on airbnb:master.

@mistercrunch mistercrunch merged commit 9a08c45 into apache:master May 3, 2016
@mistercrunch
Copy link
Member

Thanks for the PR!

@itajaja itajaja deleted the additional-pg-grains branch May 3, 2016 19:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants