Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split sunburst breadcrumb names on '_' to apply ' '-dependent wrapping more freqently #376

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

williaster
Copy link
Contributor

breadcrumb text is written in a way that wraps long label names based on word breaks. this doesn't work for words_separated_by_underscores, so this PR replaces _ in breadcrumbs names with so that long labels wrap more often.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 78d64ec on airbnb:split-sunburst-on-_ into afcdcf0 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.402% when pulling 78d64ec on split-sunburst-on-_ into afcdcf0 on master.

@mistercrunch
Copy link
Member

👍

@mistercrunch mistercrunch merged commit d96b634 into master Apr 19, 2016
@williaster williaster deleted the split-sunburst-on-_ branch April 19, 2016 21:48
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
…pache#376)

* feat(legacy-plugin-chart-country-map): migrate and replace india map with smaller file

* fix: lint

* chore: move files

* docs: update storybook

* docs: wire storybook

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
…pache#376)

* feat(legacy-plugin-chart-country-map): migrate and replace india map with smaller file

* fix: lint

* chore: move files

* docs: update storybook

* docs: wire storybook

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
…pache#376)

* feat(legacy-plugin-chart-country-map): migrate and replace india map with smaller file

* fix: lint

* chore: move files

* docs: update storybook

* docs: wire storybook

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
…pache#376)

* feat(legacy-plugin-chart-country-map): migrate and replace india map with smaller file

* fix: lint

* chore: move files

* docs: update storybook

* docs: wire storybook

* fix: lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.9 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants