feat(urlParam): new locale urlparam embedding to setup language for traductions

superset-frontend/src/components/Loading/index.tsx

@@ -16,10 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-
+import { useEffect, useState } from 'react';
 import { styled } from '@superset-ui/core';
 import cls from 'classnames';
-import Loader from 'src/assets/images/loading.gif';
 
 export type PositionOption =
   | 'floating'
@@ -61,6 +60,38 @@
   image,
   className,
 }: Props) {
+  const [Loader, setLoader] = useState<string | undefined>(undefined);
+  useEffect(() => {
+    console.log('Fetching loader...');
+    fetch('/superset/loader/', {
+      method: 'GET',
+      credentials: 'include',
+    })
+      .then(response => {
+        console.log('Response status:', response.status);
+        if (!response.ok) {
+          if (response.status === 401) {
+            console.error('User is not authenticated');
+          } else if (response.status === 403) {
+            console.error('User does not have permission to access this endpoint');
+          }
+          throw new Error(`HTTP error! status: ${response.status}`);
+        }
+        return response.json();
+      })
+      .then(data => {
+        console.log('Received data:', data);
+        // Vérifie si l'objet a une clé "src" et l'assigne
+        if (data?.src) {
+          setLoader(data.src);
+        } else {
+          console.warn('No "src" found in loader data');
+        }
+      })
+      .catch(error => {
+        console.error('Error fetching loader:', error);
+      });
+  }, []);
   return (
     <LoaderImg
       className={cls('loading', position, className)}

superset-frontend/src/constants.ts

@@ -111,6 +111,10 @@ export const URL_PARAMS = {
     name: 'focused_chart',
     type: 'number',
   },
+  locale: {
+    name: 'locale',
+    type: 'string',
+  },
 } as const;
 
 export const RESERVED_CHART_URL_PARAMS: string[] = [

superset/app.py

@@ -19,12 +19,14 @@
 import os
 from typing import Optional
 
-from flask import Flask
+from flask import Flask, request, session
+from flask_babel import Babel
 
 from superset.initialization import SupersetAppInitializer
 
 logger = logging.getLogger(__name__)
 
+babel = Babel()
 
 def create_app(superset_config_module: Optional[str] = None) -> Flask:
     app = SupersetApp(__name__)
@@ -46,6 +48,9 @@
         logger.exception("Failed to create app")
         raise
 
+@babel.localeselector
+def get_locale():
+   return session.get('locale') or request.accept_languages.best_match(['en', 'fr'])  # add here supported languages
 
 class SupersetApp(Flask):
     pass

superset/config.py

@@ -98,16 +98,6 @@
 PACKAGE_JSON_FILE = str(files("superset") / "static/assets/package.json")
 
 
-# Multiple favicons can be specified here. The "href" property
-# is mandatory, but "sizes," "type," and "rel" are optional.
-# For example:
-# {
-#     "href":path/to/image.png",
-#     "sizes": "16x16",
-#     "type": "image/png"
-#     "rel": "icon"
-# },
-FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
 
 
 def _try_json_readversion(filepath: str) -> str | None:
@@ -311,6 +301,22 @@ def _try_json_readsha(filepath: str, length: int) -> str | None:
 # Specify the App icon
 APP_ICON = "/static/assets/images/superset-logo-horiz.png"
 
+# Multiple favicons can be specified here. The "href" property
+# is mandatory, but "sizes," "type," and "rel" are optional.
+# For example:
+# {
+#     "href":path/to/image.png",
+#     "sizes": "16x16",
+#     "type": "image/png"
+#     "rel": "icon"
+# },
+FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+
+# Specify the gif file path to setup your custom loader.
+# In config.py this is the default superset loader.
+# You can setup your own in superset_config.py
+LOADER = {"src": "/static/assets/images/loading.gif"}
+
 # Specify where clicking the logo would take the user'
 # Default value of None will take you to '/superset/welcome'
 # You can also specify a relative URL e.g. '/superset/welcome' or '/dashboards/list'

superset/templates/superset/basic.html

@@ -14,6 +14,7 @@
   {% import 'appbuilder/general/lib.html' as lib %} {% from
   'superset/partials/asset_bundle.html' import css_bundle, js_bundle with context
   %} {% set favicons = appbuilder.app.config['FAVICONS'] %}
+  {% set loaders = appbuilder.app.config['LOADER'] %}
   {% import "superset/macros.html" as macros %}
   <html>
     <head>
@@ -74,9 +75,10 @@
     <body {% if standalone_mode %}class="standalone" {% endif %}>
       {% block navbar %} {% if not standalone_mode %} {% include
       'appbuilder/navbar.html' %} {% endif %} {% endblock %} {% block body %}
-      <div id="app" data-bootstrap="{{ bootstrap_data }}">
+      <div id="app" data-bootstrap="{{ bootstrap_data }}" {% if standalone_mode %}  {% endif %}>
+        {% for loader in loaders %}
         <img
-          src="{{ assets_prefix }}/static/assets/images/loading.gif"
+          src="{{ assets_prefix }}{{loader.src}}"
           style="
             width: 50px;
             position: absolute;
@@ -85,6 +87,7 @@
             transform: translate(-50%, -50%);
           "
         />
+        {% endfor %}
       </div>
       {% endblock %}
 
@@ -133,5 +136,6 @@ <h4 data-test="modal-title" class="modal-title"></h4>
           });
         });
       </script>
+
     </body>
   </html>

superset/views/base.py

@@ -33,6 +33,7 @@
     redirect,
     Response,
     session,
+    request
 )
 from flask_appbuilder import BaseView, expose, Model, ModelView
 from flask_appbuilder.actions import action
@@ -46,7 +47,7 @@
 )
 from flask_appbuilder.security.sqla.models import User
 from flask_appbuilder.widgets import ListWidget
-from flask_babel import get_locale, gettext as __
+from flask_babel import get_locale, gettext as __, refresh
 from flask_jwt_extended.exceptions import NoAuthorizationError
 from flask_wtf.form import FlaskForm
 from sqlalchemy.orm import Query
@@ -348,8 +349,19 @@
 
 
 def common_bootstrap_payload() -> dict[str, Any]:
+    # get locale from URL, else use default locale
+    locale = get_locale()
+    if request.args.get('locale'):
+        try:
+            locale = Locale.parse(request.args.get('locale'))
+            session['locale'] = str(locale)
+            refresh()
+        except Exception as e:
+            # Manage invalid locale : keep default locale
+            app.logger.warning(f"Invalid locale '{request.args.get('locale')}': {e}")
+
     return {
-        **cached_common_bootstrap_data(utils.get_user_id(), get_locale()),
+        **cached_common_bootstrap_data(utils.get_user_id(), locale),
         "flash_messages": get_flashed_messages(with_categories=True),
     }
 

superset/views/core.py

@@ -23,7 +23,7 @@
 from typing import Any, Callable, cast
 from urllib import parse
 
-from flask import abort, flash, g, redirect, request, Response
+from flask import abort, flash, g, redirect, request, Response, jsonify
 from flask_appbuilder import expose
 from flask_appbuilder.security.decorators import (
     has_access,
@@ -855,7 +855,7 @@
             url = f"{url}&{original_params}"
         if hash_ := state.get("anchor", state.get("hash")):
             url = f"{url}#{hash_}"
         return redirect(url)
 
     @api
     @has_access
@@ -925,3 +925,13 @@
     @deprecated(new_target="/sqllab/history")
     def sqllab_history(self) -> FlaskResponse:
         return redirect("/sqllab/history")
+
+    @has_access
+    @api
+    @expose("/loader/", methods=("GET",))
+    def get_loader(self) -> FlaskResponse:
+        """
+        Expose the custom LOADERS configuration via an API endpoint.
+        """
+        loader = app.config.get("LOADER", {})
+        return jsonify(loader)