refactor(bulk_select): Fix bulk select tagging issues for users #31631
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Incomplete Error Notification for Skipped Items ▹ view | |
 |
Improve error handling for bulk tag creation API. ▹ view | |
|
Generic Error Message in Catch Block ▹ view | |
|
Improper handling of SupersetSecurityException. ▹ view | |
 |
Lost Error Context in Catch Block ▹ view |
Suppressed issues based on your team's Korbit activity
| This issue | Is similar to | Because |
|---|---|---|
|
The catch block silently swallows the SupersetSecurityException without logging the error details or context |
Similar issues were not addressed in the past |
When you react to issues (for example, an upvote or downvote) or you fix them, Korbit will tune future reviews based on these signals.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/features/tags/BulkTagModal.tsx | ✅ |
| superset/commands/tag/create.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| except SupersetSecurityException: | ||
| self._skipped_tagged_objects.add((obj_type, obj_id)) |
There was a problem hiding this comment.
Improper handling of SupersetSecurityException. 
Tell me more
The code is catching a SupersetSecurityException and simply adding the object to a skipped list without properly handling the exception. Ignoring security exceptions can potentially lead to unauthorized access. Consider logging the exception, notifying the user about the lack of access, and evaluating if execution should be halted in such cases. Skipping objects due to security exceptions should be done cautiously with proper logging.
Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31631 +/- ##
===========================================
+ Coverage 60.48% 70.49% +10.00%
===========================================
Files 1931 2037 +106
Lines 76236 82076 +5840
Branches 8568 9365 +797
===========================================
+ Hits 46114 57858 +11744
+ Misses 28017 21943 -6074
- Partials 2105 2275 +170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LevisNgigi
force-pushed
the
fix-tagging
branch
from
80945ca to
79084f1
Compare
geido
added
hold!
|
Hey. Thanks for this. Do you think we could add tests to avoid the issue will be reintroduced in the future? |
There was a problem hiding this comment.
@LevisNgigi Something is off. When trying to bulk select and add a tag, instead of adding the existing tag, it is creating an entirely new tag. Can you please check that?
DEV.Superset.mp4
@geido Thank you, I have fixed the bug. |
fix(bulk_select): allow users to tag a saved query if using bulk select
SUMMARY
This PR addresses an issue where users were unable to tag objects despite having the necessary permissions. The changes ensure that the tagging functionality correctly validates user ownership or edit permissions and allows tagging where applicable. Additionally, it refines error handling to avoid unnecessary warnings while maintaining robust validation for invalid objects.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Note that you'll need to have the feature flag TAGGING_SYSTEM enabled and create a tag in the Tags page (in Settings) first before going through the repro steps.
ADDITIONAL INFORMATION