feat(embedded): Disable share clickable links for chart and tab title if can_export
permission is missing
#31359
+64
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
While in embedded mode, one could argue that sharing should be disabled since the links do not work in embed mode and clicking them will redirect a
GUEST_USER
to thestandalone
version of superset and will hit a "login wall".Such a share link is http://localhost:8088/superset/dashboard/p/4aRGDe0MLmo/. See the screenshot below.
In my experience it is enough to:
GUEST_ROLE_NAME
lacks the following permissionsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Clickable links
TESTING INSTRUCTIONS
I used a user WITHOUT the following permissions
ADDITIONAL INFORMATION