Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent multiple pvm errors on migration #31332

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: prevent multiple pvm errors on migration #31332

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bea58b7
add indexes to catalog perms
eschutho Dec 6, 2024
7fbaf99
add index to new migration
eschutho Dec 6, 2024
ea13294
add checks before dropping
eschutho Dec 6, 2024
fc45193
add duplicate view name entry error handling
eschutho Dec 7, 2024
8ba02ec
do not delete existing PVMs
eschutho Dec 10, 2024
5e2ef61
revert migration changes
eschutho Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions superset/migrations/shared/catalogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,9 @@ def upgrade_schema_perms(
.filter_by(name=current_perm)
.one_or_none()
):
existing_pvm.name = new_perm
# check that new_perm does not exist
if not session.query(ViewMenu).filter_by(name=new_perm).one_or_none():
existing_pvm.name = new_perm
elif new_perm:
# new schema discovered, need to create a new permission
perms[new_perm] = ("schema_access",)
Expand Down Expand Up @@ -683,7 +685,9 @@ def downgrade_schema_perms(
None,
schema,
)
pvms_to_rename.append((pvm, new_name))
# check to see if the new name already exists
if not session.query(ViewMenu).filter_by(name=new_name).one_or_none():
pvms_to_rename.append((pvm, new_name))
else:
# non-default catalog, delete schema perm
pvms_to_delete.append(pvm)
Expand Down
Loading