Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fine-grain chart data telemetry #31273

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: fine-grain chart data telemetry #31273

merged 2 commits into from
Dec 10, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add fine-grain logging to the chart data API endpoint, including:

  • fetching rows
  • loading data into a dataframe
  • post-processing
  • serializing to JSON

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Dec 3, 2024
@betodealmeida betodealmeida marked this pull request as ready for review December 4, 2024 18:05
@dosubot dosubot bot added api:charts Related to the REST endpoints of charts logging Creates a UI or API endpoint that could benefit from logging. labels Dec 4, 2024
@betodealmeida betodealmeida merged commit d6a82f7 into master Dec 10, 2024
47 of 59 checks passed
@rusackas rusackas deleted the chart-telemetry-log branch December 10, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
api:charts Related to the REST endpoints of charts api Related to the REST API logging Creates a UI or API endpoint that could benefit from logging. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betodealmeida @eschutho