-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New viz: box plot #312
New viz: box plot #312
Conversation
This looks amazing! I can take care of the image later (I just added a feature that shows the thumbnail in the viz_type dropdown in the explroe view (#313)). It's as simple as creating a 1024*1024 png and dropping it in So the javascript linter is aggressive and breaks the build. You can run |
Ah, I did not do that. Just pushed changes to make the linters happy. Hopefully all good now |
This is great! Picture the diversity of the visualization Caravel will be able to offer if only a few of us can contribute new visualizations on a regular basis. Also I would love feedback and thoughts on how to improve the framework, and make it easier to add new visualizations. For instance we were thinking about moving the form controls on the javascript side, and using React to wrap the components. |
great |
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Hi,
This PR implements an NVD3 box plot (shown below). I added an example slice so it's picked up in the tests.
There is one custom option for box plots for the user to select the whisker calculation method (options are currently Tukey or quartiles +- 1.5*IQR, min/max, 2nd/98th percentile, or 9th/91st percentiles, although easy to add more).
I wasn't sure how to add an image in the gallery, so that's not in this PR, apologies.
I also wasn't 100% on how the
color
function is supposed to work (it seems to recurse through attributes which are lists). For the box plot data structure required by NVD3 to work, I had to add a null check in the color function as the 'outliers' attribute only contains data. Consequently all outliers are all colored black, although I don't think this is a problem.