Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package.json): Pin luxon version to unblock master #30859

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix(package.json): Pin luxon version to unblock master #30859

merged 1 commit into from
Nov 6, 2024

Conversation

geido
Copy link
Member

@geido geido commented Nov 6, 2024

SUMMARY

Master is currently broken due to a mismatch with luxon version. This PR pins the version in the package.json to unblock master.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. npm ci should run successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido merged commit de8282c into master Nov 6, 2024
34 of 35 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 13, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@geido @sadpandajoe
fix(package.json): Pin luxon version to unblock master (#30859)
282e878 
(cherry picked from commit de8282c)
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@geido @sadpandajoe
fix(package.json): Pin luxon version to unblock master (#30859)
f704b0f 
(cherry picked from commit de8282c)
@sadpandajoe sadpandajoe linked an issue Nov 15, 2024 that may be closed by this pull request
Invalid: lock file's [email protected] does not satisfy [email protected] #30928
Closed
3 tasks
jarethholt pushed a commit to raysearchlabs/superset that referenced this pull request Nov 19, 2024
@geido @jarethholt
fix(package.json): Pin luxon version to unblock master (apache#30859)
446cd0a 
(cherry picked from commit de8282c)
michael-s-molina pushed a commit that referenced this pull request Nov 20, 2024
@geido @michael-s-molina
fix(package.json): Pin luxon version to unblock master (#30859)
bf69d48 
(cherry picked from commit de8282c)
michael-s-molina pushed a commit that referenced this pull request Nov 20, 2024
@geido @michael-s-molina
fix(package.json): Pin luxon version to unblock master (#30859)
9c2a3eb 
(cherry picked from commit de8282c)
@mistercrunch mistercrunch added 🍒 4.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 27, 2024
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@geido @nyohasstium
fix(package.json): Pin luxon version to unblock master (apache#30859)
218377e
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
@geido @sadpandajoe
fix(package.json): Pin luxon version to unblock master (#30859)
6cef2e9 
(cherry picked from commit de8282c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadpandajoe sadpandajoe sadpandajoe approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@kgabryje kgabryje Awaiting requested review from kgabryje

@Antonio-RiveroMartnez Antonio-RiveroMartnez Awaiting requested review from Antonio-RiveroMartnez

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependencies:npm size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid: lock file's [email protected] does not satisfy [email protected]
3 participants
@geido @sadpandajoe @mistercrunch