Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TimezoneSelector): Failing unit tests due to timezone change #30828

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(TimezoneSelector): Failing unit tests due to timezone change #30828

merged 1 commit into from
Nov 4, 2024

Conversation

geido
Copy link
Member

@geido geido commented Nov 4, 2024

SUMMARY

The TimezoneSelector unit tests were failing due to timers not resetting correctly and several errors in handling actual timezone changes between Standard and Daylight time.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

Unit tests should not fail

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the global:timezone Related to timezones label Nov 4, 2024
Antonio-RiveroMartnez
Antonio-RiveroMartnez approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geido geido merged commit 5820d31 into master Nov 4, 2024
35 of 37 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 4, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@geido @sadpandajoe
fix(TimezoneSelector): Failing unit tests due to timezone change (#30828
7953c89 
)

(cherry picked from commit 5820d31)
michael-s-molina pushed a commit that referenced this pull request Nov 19, 2024
@geido @michael-s-molina
fix(TimezoneSelector): Failing unit tests due to timezone change (#30828
938b1fd 
)

(cherry picked from commit 5820d31)
@mistercrunch mistercrunch added 🍒 4.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 27, 2024
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@geido @nyohasstium
fix(TimezoneSelector): Failing unit tests due to timezone change (apa…
aaafee8 
…che#30828)
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
@geido @sadpandajoe
fix(TimezoneSelector): Failing unit tests due to timezone change (#30828
70d60c8 
)

(cherry picked from commit 5820d31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:timezone Related to timezones size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.1
Projects
No open projects
Apache Superset 4.1.1
Status: Cherried
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @Antonio-RiveroMartnez @mistercrunch @sadpandajoe