Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Jinja): Extra cache keys for calculated columns and metrics using Jinja #30735

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix(Jinja): Extra cache keys for calculated columns and metrics using Jinja #30735

merged 3 commits into from
Oct 29, 2024

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

This is a follow up to #30715. It adds logic to check Jinja in calculated columns and also metrics (both ad-hoc and from the dataset level).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No UI changes.

TESTING INSTRUCTIONS

Added testing to this flow.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Vitor-Avila Vitor-Avila requested review from villebro and geido October 28, 2024 21:29
@dosubot dosubot bot added the global:jinja Related to Jinja templating label Oct 28, 2024
villebro
villebro reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - a few comments regarding the tests

tests/integration_tests/sqla_models_tests.py Outdated Show resolved Hide resolved
tests/integration_tests/sqla_models_tests.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 28, 2024
@Vitor-Avila Vitor-Avila requested a review from villebro October 28, 2024 22:00
@Vitor-Avila
Copy link
Contributor Author

@villebro thanks for initial pass 🙏 I addressed your feedback + removed a redundant import. Let me know if you have any questions!

villebro
villebro approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vitor-Avila Vitor-Avila merged commit 09d3f60 into master Oct 29, 2024
33 checks passed
sadpandajoe pushed a commit that referenced this pull request Oct 29, 2024
@Vitor-Avila @sadpandajoe
fix(Jinja): Extra cache keys for calculated columns and metrics using…
ba0d118 
… Jinja (#30735)

(cherry picked from commit 09d3f60)
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 29, 2024
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:jinja Related to Jinja templating size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vitor-Avila @villebro @geido @mistercrunch @sadpandajoe