fix(explore): column data type tooltip format #30588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
reviewed
Oct 15, 2024
| @@ -55,8 +55,7 @@ const TooltipSection = ({ | |||
| text: ReactNode; | |||
| }) => ( | |||
| <TooltipSectionWrapper> | |||
| <TooltipSectionLabel>{label}</TooltipSectionLabel> | |||
| <span>{text}</span> | |||
| <TooltipSectionLabel>{label}</TooltipSectionLabel>: <span>{text}</span> | |||
There was a problem hiding this comment.
might be a legit use case for a
There was a problem hiding this comment.
Also not sure the span has any real purpose here. ¯\_(ツ)_/¯
There was a problem hiding this comment.
I had a {' '} and I think prettier changed it to what is now there. Generally I prefer the {' '} to , and if prettier is configured to do what it did, let's roll with it. About the span, I think it's referenced in the CSS so that it's not bolded.
mistercrunch
requested review from
villebro,
geido,
eschutho,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
i18n
rusackas
reviewed
Oct 29, 2024
helm/superset/README.md
Outdated
| @@ -23,7 +23,7 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs | |||
|
|
|||
| # superset | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Just curious, why did we have a minor bump? Still figuring out the rhyme or reason of helm version numbers.
n/m it's the addition of extraLablels... I see.
rusackas
reviewed
Oct 29, 2024
rusackas
reviewed
Oct 29, 2024
rusackas
reviewed
Oct 29, 2024
rusackas
reviewed
Oct 29, 2024
superset-frontend/packages/superset-ui-chart-controls/package.json
Outdated
Show resolved
Hide resolved
|
And here I am adding review comments all over what looks like a funky rebase. I was about to comment "what is the scope of this PR?" 🤦 |
|
Oops, gitfu fail, got thrown off by a local rebate + merged a commit from the PR |
Minor visual tweak to add a column and a space inside the Explore -> LeftPanelDatasetView -> Column datatype tooltip
mistercrunch
force-pushed
the
explore_left_metadata_type
branch
from
230c5f5 to
2b54e6d
Compare
github-actions
bot
removed
i18n
rusackas
approved these changes
Oct 30, 2024
sadpandajoe
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 73768f6)
sadpandajoe
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 73768f6)
michael-s-molina
pushed a commit
that referenced
this pull request
Nov 19, 2024
(cherry picked from commit 73768f6)
mistercrunch
added
🍒 4.1.1
🏷️ bot
betodealmeida
pushed a commit
that referenced
this pull request
Jan 14, 2025
(cherry picked from commit 73768f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor visual tweak to add a column and a space inside the Explore -> LeftPanelDatasetView -> Column datatype tooltip.
Adding a colon and a space, and showing the data type as uppercase as it's pretty standard to expose it in that way elsewhere in Superset and as a general convention
before
after