fix(filters): Adds a fix for saving time range adhoc_filters #30581
+75
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aveModalActions.ts
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closed
3 tasks
michael-s-molina
added
review:checkpoint
|
@ObservabilityTeam could you fill the PR template with a proper description? Can you also add tests for the fix? |
michael-s-molina
removed
the
review:checkpoint
Yes, it will be looked into soon. |
|
I have added a test for the fix. The PR description has also been updated. Please let me know if you require anything else, thanks. |
michael-s-molina
approved these changes
Oct 15, 2024
|
Thank you for the fix @ObservabilityTeam |
Closed
3 tasks
michael-s-molina
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Oct 15, 2024
Co-authored-by: Muhammad Musfir <[email protected]> (cherry picked from commit 2c3ba95)
mistercrunch
pushed a commit
that referenced
this pull request
Oct 28, 2024
Co-authored-by: Muhammad Musfir <[email protected]>
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aveModalActions.ts
SUMMARY
The bug occurs when you have a mixed time series chart inside a dashboard and the time range filter from the dashboard does not apply to both queries of the mixed time series chart. If you compare the changes, the previous code would only take care of the adhoc_filters key. The changes make sure that all the adhoc filters keys of the regex /^adhoc_filters/ receive the adhoc time range filter. In case of mixed time series there are two keys namely, adhoc_filters and adhoc_filters_b.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
For manual testing, here is the link of the issue with reproduction steps. You can verify the fix by following them.
ADDITIONAL INFORMATION