Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uploads): respect db engine spec's supports_multivalues_insert value for file uploads & enable multi-insert for MSSQL #30222

Merged
merged 9 commits into from
Sep 12, 2024
Merged

fix(uploads): respect db engine spec's supports_multivalues_insert value for file uploads & enable multi-insert for MSSQL #30222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2bfd42
read multivalues_insert value from Superset db_engine specs
sfirke Sep 10, 2024
e97d510
set mssql to use multiple inserts
sfirke Sep 5, 2024
77a6d0b
fix whitespace
sfirke Sep 10, 2024
3abf564
fixed by ruff-format
sfirke Sep 10, 2024
217ad1f
set default value of multi-values insert in base spec
sfirke Sep 11, 2024
cffded5
cls.supports_multivalues_insert will always be defined
sfirke Sep 11, 2024
125a00d
Merge branch 'apache:master' into fix-multivalues-insert
sfirke Sep 11, 2024
779bd6b
simplify first conditional to prior state - attribute should be set
sfirke Sep 11, 2024
94550af
ruff-format
sfirke Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions superset/db_engine_specs/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
# Does database support join-free timeslot grouping
time_groupby_inline = False
limit_method = LimitMethod.FORCE_LIMIT
supports_multivalues_insert = False
allows_joins = True
allows_subqueries = True
allows_alias_in_select = True
Expand Down Expand Up @@ -1283,9 +1284,11 @@ def df_to_sql(
catalog=table.catalog,
schema=table.schema,
) as engine:
if engine.dialect.supports_multivalues_insert:
if (
engine.dialect.supports_multivalues_insert
or cls.supports_multivalues_insert
):
to_sql_kwargs["method"] = "multi"

df.to_sql(con=engine, **to_sql_kwargs)

@classmethod
Expand Down
1 change: 1 addition & 0 deletions superset/db_engine_specs/mssql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class MssqlEngineSpec(BaseEngineSpec):
max_column_name_length = 128
allows_cte_in_subquery = False
allow_limit_clause = False
supports_multivalues_insert = True
sfirke marked this conversation as resolved.
Show resolved Hide resolved

_time_grain_expressions = {
None: "{col}",
Expand Down
Loading