-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run babel_update.sh to update po files #29476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Periodically we need to run this script to rebuild the list of translatable strings from static analysis of the code base.
9 tasks
rusackas
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And the codebase is getting not just more maintainable, but also smaller, which is always good in my book!
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
doc
Namespace | Anything related to documentation
github_actions
Pull requests that update GitHub Actions code
i18n:brazilian
i18n:chinese
Translation related to Chinese language
i18n:dutch
i18n:french
Translation related to French language
i18n:general
Related to translations
i18n:italian
Translation related to Italian language
i18n:japanese
Translation related to Japanese language
i18n:korean
Translation related to Korean language
i18n:portuguese
i18n:russian
Translation related to Russian language
i18n:slovak
i18n:spanish
Translation related to Spanish language
i18n:traditional-chinese
i18n:ukrainian
i18n
Namespace | Anything related to localization
preset-io
size/XXL
🚢 4.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Periodically we need to run this script to rebuild the list of translatable strings from static analysis of the code base.
Also adding
--no-location
topybabel extract
fixing merge conflicts issues we've been having around these .po files.Also fixing the docs builds, they've been broken.
About the fact that merge conflicts are really tricky around translation work in general, I was thinking it may be doable to write a simple utility that would strip all comments from po files, as they are just comments referencing where the msgid exists, and operate at that level if/when needed. Like you hit a merge conflict, strip both files from comment, diff them, and commit without comments. I think the next pybabel script run would bring back the comments.~~Maybe we even want to pass a flag to pybabel to compeltely avoid adding source references as comments. We'd loose the ability to easily find where the string lives in the codebase, but for that you can just
git grep
. ~~