Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): Remove unnecessary mock #29386

Merged
merged 1 commit into from
Jun 27, 2024
Merged

chore(tests): Remove unnecessary mock #29386

merged 1 commit into from
Jun 27, 2024

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jun 27, 2024 •
edited
Loading

SUMMARY

It seems like some tests incorrectly mock the TestConnectionDatabaseCommand command, yet this should be executed given that the validation will raise the appropriate error prior to actually creating the database.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review June 27, 2024 01:05
@dosubot dosubot bot added the need:tests This PR requires tests label Jun 27, 2024
@john-bodley john-bodley merged commit 9d40573 into master Jun 27, 2024
61 of 62 checks passed
@john-bodley john-bodley deleted the john-bodley--tests-remove-mock branch June 27, 2024 14:28
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@john-bodley @eschutho
chore(tests): Remove unnecessary mock (#29386)
e626817
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:tests This PR requires tests size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-bodley @michael-s-molina @mistercrunch