Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): using updated repo secret, new Cypress project id #29296

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jun 18, 2024

SUMMARY

Our old key was in the codebase... le sigh.

This PR uses a new Cypress project id, and a new repo secret already put in place by ASF. We'll need to merge this to continue making changes on the Cypress dashboard side.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Hopefully we can kick off a manual test run with Dashboard recording. Otherwise, merge and see if it works there!

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member Author

@mistercrunch what's the way to manually trigger a test run with Cypress dashboard, again? I'd like to do that here if possible.

@rusackas rusackas merged commit 36b1535 into master Jun 19, 2024
37 checks passed
@mistercrunch
Copy link
Member

mistercrunch commented Jun 20, 2024

@rusackas to trigger, on this page -> https://github.com/apache/superset/actions/workflows/superset-e2e.yml, hit "Run Workflow"
Screenshot 2024-06-20 at 12 34 55 PM

Can also use the CLI, something like gh workflow run superset-e2e.yml --ref cypress_when_needed --field use_dashboard="true" --field pr_id="29077"

Where --ref points to a remote branch on apache/

@rusackas rusackas deleted the cypress-touchups branch June 20, 2024 20:51
@rusackas
Copy link
Member Author

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code preset-io size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants