refactor(sqllab): nonblocking new query editor #28795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
frontend:refactor
justinpark
requested review from
rusackas,
betodealmeida,
eschutho and
michael-s-molina
|
/testenv up FEATURE_SQLLAB_BACKEND_PERSISTENCE=true |
|
@justinpark Ephemeral environment spinning up at http://54.202.253.165:8080. Credentials are |
| queries, | ||
| ) { | ||
| return function (dispatch) { | ||
| export function migrateQueryEditorFromLocalStorage(queryEditor) { |
There was a problem hiding this comment.
Is this a migration or you're syncing the query editor state with the backend? If you're syncing the state, could you rename this function to syncQueryEditor and add a JSDoc explaining that it syncs the values in the local storage with the backend?
| @@ -467,7 +467,16 @@ function migrateQuery(queryId, queryEditorId, dispatch) { | |||
| ); | |||
| } | |||
|
|
|||
| export function migrateQueryEditorFromLocalStorage(queryEditor) { | |||
| /** | |||
michael-s-molina
approved these changes
Jun 4, 2024
|
Ephemeral environment shutdown and build artifacts deleted. |
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up #24539
This commit modifies the
addQueryEditorfunction to asynchronously handle the process of creating a queryEditor in localStorage in the same way as in non-persistent mode and periodically saving the queryEditor state to persistence via AutoSync'smigrateQueryEditorFromLocalStorage.This commit made the following changes:
In persistence mode, new tabs can now open and access data directly from localStorage without the delays caused by network or database latency.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--nonblocking-creation.mov
After:
after--nonblocking-creation.mov
TESTING INSTRUCTIONS
Set SQLLAB_PERSISTENCE_MODE on and then open a multiple tabs
please reload the page and then check all tabs are persisted
ADDITIONAL INFORMATION