feat: Adds Histogram chart migration logic #28780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
force-pushed
the
add-echarts-histogram-migration
branch
from
b7eeed8 to
687f159
Compare
github-actions
bot
added
risk:db-migration
dosubot
bot
added
viz:charts:echarts
michael-s-molina
commented
Jun 5, 2024
| @@ -25,8 +25,10 @@ export default function buildQuery(formData: HistogramFormData) { | |||
| return buildQueryContext(formData, baseQueryObject => [ | |||
| { | |||
| ...baseQueryObject, | |||
| extras: { where: `${column} IS NOT NULL` }, | |||
There was a problem hiding this comment.
Given that column can only contain numeric values, we automatically exclude NULL values from the result. This also aligns better with the limit control.
michael-s-molina
commented
Jun 5, 2024
| @@ -53,7 +53,7 @@ def histogram( | |||
| raise ValueError(f"The column '{column}' must be numeric.") | |||
|
|
|||
| # calculate the histogram bin edges | |||
| bin_edges = np.histogram_bin_edges(df[column], bins=bins) | |||
| bin_edges = np.histogram_bin_edges(df[column].dropna(), bins=bins) | |||
There was a problem hiding this comment.
I added the dropna() to deal with NULL values independently of the query results.
michael-s-molina
commented
Jun 5, 2024
| columns: [...groupby, column], | ||
| post_processing: [histogramOperator(formData, baseQueryObject)], | ||
| metrics: undefined, |
There was a problem hiding this comment.
metrics by default is [] but we need it to be undefined to avoid a GROUP BY.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28780 +/- ##
==========================================
+ Coverage 60.48% 70.26% +9.77%
==========================================
Files 1931 1951 +20
Lines 76236 77607 +1371
Branches 8568 8756 +188
==========================================
+ Hits 46114 54528 +8414
+ Misses 28017 20954 -7063
- Partials 2105 2125 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds the Histogram chart migration logic (legacy ➡️ ECharts). Users can execute this migration using the CLI command and disable the legacy version with the VIZ_TYPE_DENYLIST configuration.
This PR also improves the Histogram chart to automatically handle
NULLvalues.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Upgrade a Histogram (legacy) chart using the CLI command
2 - Check the new chart
3 - Downgrade a Histogram (legacy) chart using the CLI command
4 - Check the legacy chart
ADDITIONAL INFORMATION