chore: make docker-compose use less memory #28773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playing a few tricks to make docker-compose use less memory: - not starting the `superset-tests-worker` service on a normal `docker-compose up` by using `profile`. From my understanding this service is used only by `scripts/tests/run.sh`, and it starts/stops it on its own - doesn't assume its already running. This saves ~900MB, while maintaining 8 workers to run tests by default, but makes it confiurable if you wanted more you could more easily change it now - starting only 2 workers by default for `superset-worker` as opposed to the default of 8, which is not necessary for dev workflows. This saves maybe ~600MB
rusackas
reviewed
May 30, 2024
rusackas
approved these changes
May 30, 2024
There was a problem hiding this comment.
Added a teensy suggestion to clarify the comment a bit. Not sure if it's worth adding a comment in the docker-compose.yml file as well for clarity. This may or may not be worth a mention on the docs site, too, if you think it might be something people fiddle with much. Aside from those nits, LGTM!
Co-authored-by: Evan Rusackas <[email protected]>
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
Co-authored-by: Evan Rusackas <[email protected]>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Evan Rusackas <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing a few tricks to make docker-compose use less memory:
superset-tests-workerservice on a normaldocker-compose upby usingprofile. From my understanding this service is used only byscripts/tests/run.sh, and it starts/stops it on its own - doesn't assume its already running. This saves ~900MB, while maintaining 8 workers to run tests by default, but makes it confiurable if you wanted more you could more easily change it nowsuperset-workeras opposed to the default of 8, which is not necessary for dev workflows. This saves maybe ~500MBbefore
after