-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reports): Update the element class to wait for when taking a screenshot #28745
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28745 +/- ##
===========================================
+ Coverage 60.48% 83.47% +22.98%
===========================================
Files 1931 523 -1408
Lines 76236 37575 -38661
Branches 8568 0 -8568
===========================================
- Hits 46114 31365 -14749
+ Misses 28017 6210 -21807
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
In the process of taking screenshots for an alert/report, Selenium/Playwright is configured to wait a certain time (controlled via
superset_config.py
) until all chart elements are drawn. The logic was configured to monitor theslice_container
class, however with #27255 this class is only used once the chart data is retrieved.This PR changes the class to be monitored to the
chart-container
wrapper.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
TESTING INSTRUCTIONS
SCREENSHOT_LOCATE_WAIT
to be 30 seconds, andSCREENSHOT_LOAD_WAIT
to be 200 seconds.pg_sleep()
with Postgres for example.Before this PR the report would fail, as the chart wouldn't load within 30 seconds.
ADDITIONAL INFORMATION