feat(plugins): Make comparison values on BigNumberPeriodOverPeriod toggleable

[mkramer5454]

SUMMARY

There are various scenarios where it is preferred to only show a subset of the three comparison values: previous period value, period difference, and period percent change. This change allows for hiding unwanted values.

(This is my first contribution on the frontend side so please let me know if I missed something obvious!)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

optional_comparison_diplays.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: CHART_PLUGINS_EXPERIMENTAL
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[eschutho]

/testenv up

[Antonio-RiveroMartnez]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

[github-actions]

@Antonio-RiveroMartnez Ephemeral environment spinning up at http://35.93.65.110:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[fontclos]

@eschutho any chance this gets reviewed and merged? We'd very much love the feature!

[fontclos]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

[github-actions]

@fontclos Ephemeral environment creation is currently limited to committers.

[rusackas]

/testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true

[github-actions]

@rusackas Ephemeral environment spinning up at http://35.92.2.227:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[eschutho]

Thanks for the contribution @mkramer5454! This looks good to me. Can you write a few tests here: superset-frontend/packages/superset-ui-core/test/time-comparison/getComparisonInfo.test.ts

[eschutho]

And maybe one small UI improvement, when "Add color for positive/negative" is selected, there's an extra dialog that shows up. I'd suggest to keep the two fields together and minimize any jumpiness, we just move the "Add color" field to the bottom below the new checkboxes. Also cc @yousoph and @kasiazjc on any other design suggestions.